PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Attacks per second calculation (on poet's pen wand) possible rounding error

Open
#6,839 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

The trade site calculates "attacks per second" to 1.72 See here:
image

What is the value from the calculation in Path of Building?

If you import/copy item into pob it auto calculates it to be 1.73:
image

I am guessing this is a rounding error.

How to reproduce the issue
  1. Go to trade:

https://www.pathofexile.com/trade/search/Standard/kX7n23Qi5

  1. Copy item:
Item Class: Wands
Rarity: Unique
The Poet's Pen
Carved Wand
--------
Wand
Quality: +30% (augmented)
Physical Damage: 9-17
Critical Strike Chance: 7.00%
Attacks per Second: 1.72 (augmented)
--------
Requirements:
Level: 12
Int: 47
--------
Sockets: B-B-R 
--------
Item Level: 84
--------
Quality does not increase Physical Damage (enchant)
1% increased Attack Speed per 8% Quality (enchant)
--------
15% increased Spell Damage (implicit)
--------
+1 to Level of Socketed Skill Gems per 25 Player Levels
Trigger a Socketed Spell when you Attack with this Weapon, with a 0.25 second Cooldown
Adds 3 to 5 Physical Damage to Attacks with this Weapon per 3 Player Levels
12% increased Attack Speed
--------
In every piece of prose, lies a tiny spark of magic.
--------
Note: ~price 3 exalted
  1. See that pob thinks that 1.72 should be 1.73
Character build code
No need you can do this with any character as its just the copy/paste of the item.
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the discrepancy by importing the provided Poet's Pen item and comparing Path of Building's attack speed with the trade listing. Trace the attack-speed calculation from the item import or calculation entry point, then verify that the displayed value matches the expected 1.72 without affecting other attack-speed calculations.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.