PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Legacy game units for Projectile travel distance in Configuration
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?
In a build that has a condition that makes the "Projectile travel distance" configuration option show, the field should allow the user to enter a distance in terms of the current units used in the game.
As the game has moved to meters for (almost) all player-visible metrics, one would expect this to also be in meters.
How does Path of Building behave?
The value entered in the field seems to still be in legacy game units, as is the ProjectileDistanceCap variable and all the computations/data around the concept.
How to reproduce the issue
Select Tornado Shot as the main skill.
Allocate something that grants the configuration option like the "Adjacent Animosity" notable.
Go to Configuration.
Observe that the "Projectile travel distance" field only takes whole legacy game units.
Character build code
https://pobb.in/tVk4OpVycyL1
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema con Tornado Shot y la notable Adjacent Animosity; después, sigue el campo Configuration de "Projectile travel distance" y la variable ProjectileDistanceCap. Actualiza el manejo de la unidad mostrada y los cálculos relacionados para que el campo use metros de forma coherente, y verifica el resultado con el build code proporcionado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- backend, frontend
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100