PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Legacy game units for Projectile travel distance in Configuration
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?
In a build that has a condition that makes the "Projectile travel distance" configuration option show, the field should allow the user to enter a distance in terms of the current units used in the game.
As the game has moved to meters for (almost) all player-visible metrics, one would expect this to also be in meters.
How does Path of Building behave?
The value entered in the field seems to still be in legacy game units, as is the ProjectileDistanceCap variable and all the computations/data around the concept.
How to reproduce the issue
Select Tornado Shot as the main skill.
Allocate something that grants the configuration option like the "Adjacent Animosity" notable.
Go to Configuration.
Observe that the "Projectile travel distance" field only takes whole legacy game units.
Character build code
https://pobb.in/tVk4OpVycyL1
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce with Tornado Shot and the Adjacent Animosity notable, then trace the Configuration field for "Projectile travel distance" and the ProjectileDistanceCap variable. Update the displayed unit handling and related computations so the field uses meters consistently, and verify the result against the reported build code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100