PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Add (possibly optionally) ascendancy notables to power report
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
The ascendancy notables do not show in the node power report. I was looking for the highest dps one when searching for the forbidden flame/flesh jewels.
Describe the solution you'd like
I noticed the ascendancy notables were missing from the power report when searching for forbidden flesh/flame jewels. I don't know if there is a reason why these are omitted from the power report but it was just a 1 line fix to include them in TreeTab.lua:
if (node.type == "Normal" or node.type == "Keystone" or node.type == "Notable") and not node.ascendancyName then
can be changed to
if (node.type == "Normal" or node.type == "Keystone" or node.type == "Notable") then
I don't really know what else this impacts but it worked to include them in the power report output at least. If there is a good reason to exclude them please let me know.
Describe alternatives you've considered
the current alternative is mousing over all of them and checking them independently
Additional context
Let me know if you want to make a PR for this and I will happily do that. I tested it on the latest dev branch and it seemed to be working as expected in a quick spot check but I did not run the tests...
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne in src/Classes/TreeTab.lua ungefähr bei Zeile 666 und prüfe, wie Knoten für den Power-Report ausgewählt werden. Reproduziere die Suche nach Forbidden Flame/Flesh-Jewels und verifiziere anschließend, dass Ascendancy-Notables im Report erscheinen, ohne die Ergebnisse anderer Knoten zu ändern; im Issue wird vermerkt, dass keine Tests ausgeführt wurden.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- desktop
- Issue-Typ
- Feature
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 45/100