PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add (possibly optionally) ascendancy notables to power report

Open
#6,274 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The ascendancy notables do not show in the node power report. I was looking for the highest dps one when searching for the forbidden flame/flesh jewels.

Describe the solution you'd like

https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/19818870af754cc17b9fa8e16c026670f20932e6/src/Classes/TreeTab.lua#L666C59-L666C59

I noticed the ascendancy notables were missing from the power report when searching for forbidden flesh/flame jewels. I don't know if there is a reason why these are omitted from the power report but it was just a 1 line fix to include them in TreeTab.lua:

            if (node.type == "Normal" or node.type == "Keystone" or node.type == "Notable") and not node.ascendancyName then

can be changed to

            if (node.type == "Normal" or node.type == "Keystone" or node.type == "Notable") then

I don't really know what else this impacts but it worked to include them in the power report output at least. If there is a good reason to exclude them please let me know.

Describe alternatives you've considered

the current alternative is mousing over all of them and checking them independently

Additional context

Let me know if you want to make a PR for this and I will happily do that. I tested it on the latest dev branch and it seemed to be working as expected in a quick spot check but I did not run the tests...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Classes/TreeTab.lua around line 666 and inspect how nodes are selected for the power report. Reproduce the forbidden flame/flesh jewel search, then verify that ascendancy notables appear in the report without changing other node results; the issue notes that tests were not run.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.