PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Mask of the Tribunal RMR calculation
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Mask of the Tribunal gives "2% increased Mana Reservation Efficiency of Skills per 250 total Attributes". However if in game you reach a total of 125 attributes you already get 1% increased mana reservation efficiency and when reaching 250 total attributes you get the other 1%.
What is the value from the calculation in Path of Building?
In path of building I only get 2% increased mana reservation efficiency when reaching 250 attributes, but not not 1% on reaching 125 attributes.
How to reproduce the issue
- import the attached build
- enable discipline and haste if not already active
- allocate all small cluster jewel nodes if not already allocated
Mana will then be -1 while the exact same character has 3 open mana in game. Total attributes are 1877 - so a 125 treshhold (1875) is met but not the 250 one. If I enter "1% increased mana reservation efficiency" in custom modifiers, the mana is correct (3 open mana)
Character build code
https://pastebin.com/uGiRzHAq
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by importing the linked Pastebin build and reproducing the Mask of the Tribunal calculation with the reported attributes and enabled skills. Trace the Lua calculation for the item's mana reservation efficiency thresholds and compare the result at 125 and 250 attributes; done means the planner matches the reported in-game mana.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100