PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Crucible shield mod gets removed after editing the item
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
N/A
What is the behaviour in Path of Building?
I have a shield in PoB where I edit and add the crucible more for 3% chance to block spell damage/5% more maximum mana and save the item.
If I edit the item again the mod is still shown correctly, but if I click add crucible mod I see only the 3% chance to block spell damage attribute. After I edit a different crucible mod and go to save the item, I can see that it is applying just the spell block mod (showing a ~5% mana loss).
Shields do have a 3% spell block node so maybe PoB is reverting to the other T2 node.
How to reproduce the issue
- Create a shield
- Add the crucible mod for spell block/more mana
- Save the item
- Edit the item
- Add any other crucible mod
- Save the item
- Note the removal of the more mana mod (spell block is retained)
Character build code
https://pastebin.com/Bu8u4JH8
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the item editor using the provided build code, following the listed steps with a shield and the Crucible spell-block/more-mana mod. Trace the save and reload path for Crucible mods; the fix is complete when editing another Crucible mod no longer removes the more-mana modifier while retaining spell block.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100