PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Cast When Damage Taken support affecting linked Skill Gems that are too high level

未关闭
#6,201 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

enhancement wontfix
主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

描述

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

The Cast When Damage Taken support gem, depending on it's level, only affects linked skill gems that are below a certain required-level threshold.

What is the behaviour in Path of Building?

The Cast When Damage Taken support gem affects all linked skill gems regardless of required level.

How to reproduce the issue

Starting with a new build:

  1. Switch to the Skills tab
  2. Add a new Socket Group
  3. Add any damaging skill gem (e.g Arc) and ensure it is set to level 20
  4. Note the reported Damage and Mana Cost for that skill
    image
  5. Add the Cast When Damage Taken support gem to the group and ensure it is set to level 1
  6. Observe that Cast When Damage Taken is affecting the reported Damage and Mana Cost for the chosen skill in step 3
    image

Cast When Damage Taken should not apply to the skill in this instance, because level 20 Arc requires a character level of 70, and level 1 Cast When Damage Taken can only support skill gems requiring level 38 or lower.

Character build code
Simple Reproduction: https://pobb.in/8pUPSX500oY1

Build with incorrect warning caused by bug: https://pobb.in/qQ5Zcu2jB7EZ
Note this build has a CWDT-Hextouch socket group -- PoB reports 1 Warning that there is not enough unreserved mana to cast Despair, but this is because the 250% cost multiplier from CWDT is being applied to Despair even though its gem level is too high (see screenshots).
Screenshots

CWDT-Hextouch socket group:
image
CWDT mana cost multiplier affecting Despair:
image

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 Skills 标签页使用一个与 20 级 Arc 相连的 1 级 Cast When Damage Taken 宝石重现该问题,然后比较移除辅助宝石后的报告伤害和魔力消耗。还要检查关联的 CWDT-Hextouch build 及其魔力警告。完成的标准是,等级过高的已连接技能不再受 Cast When Damage Taken 影响。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
game-dev
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。