PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Cast When Damage Taken support affecting linked Skill Gems that are too high level

Open
#6,201 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement wontfix
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

The Cast When Damage Taken support gem, depending on it's level, only affects linked skill gems that are below a certain required-level threshold.

What is the behaviour in Path of Building?

The Cast When Damage Taken support gem affects all linked skill gems regardless of required level.

How to reproduce the issue

Starting with a new build:

  1. Switch to the Skills tab
  2. Add a new Socket Group
  3. Add any damaging skill gem (e.g Arc) and ensure it is set to level 20
  4. Note the reported Damage and Mana Cost for that skill
    image
  5. Add the Cast When Damage Taken support gem to the group and ensure it is set to level 1
  6. Observe that Cast When Damage Taken is affecting the reported Damage and Mana Cost for the chosen skill in step 3
    image

Cast When Damage Taken should not apply to the skill in this instance, because level 20 Arc requires a character level of 70, and level 1 Cast When Damage Taken can only support skill gems requiring level 38 or lower.

Character build code
Simple Reproduction: https://pobb.in/8pUPSX500oY1

Build with incorrect warning caused by bug: https://pobb.in/qQ5Zcu2jB7EZ
Note this build has a CWDT-Hextouch socket group -- PoB reports 1 Warning that there is not enough unreserved mana to cast Despair, but this is because the 250% cost multiplier from CWDT is being applied to Despair even though its gem level is too high (see screenshots).
Screenshots

CWDT-Hextouch socket group:
image
CWDT mana cost multiplier affecting Despair:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the Skills tab using a level 1 Cast When Damage Taken gem linked to a level 20 Arc, then compare the reported damage and mana cost with the support removed. Also check the linked CWDT-Hextouch build and its mana warning. Done means an over-level linked skill is no longer affected by Cast When Damage Taken.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.