PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Kitava's Thirst Bug in Calculation Bandwidth
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?
If Kitava's Thirst is equipped (helmet slot) - any input on adding skills/spells/support gems creates a massive lag. I bet this is due to the program checking every dps possibility for kitava's thirst, even if selecting a skill outside of the helmet socket skill tab.
UNEQUIPPING Kitava's thirst solves this issue.
I checked if selecting "full DPS" functionality changes the calculation (i.e. lag time) at all; it does not.
Check coding pertaining to Kitava's Thirst and add a boundary to any skill change outside of selected helmet for a shortterm fix.
How does Path of Building behave?
If Kitava's Thirst is equipped (helmet slot) - any input on adding skills/spells/support gems creates a massive lag. I bet this is due to the program checking every dps possibility for kitava's thirst, even if selecting a skill outside of the helmet socket skill tab.
I checked if selecting "full DPS" functionality changes the calculation (i.e. lag time) at all; it does not.
Check coding pertaining to Kitava's Thirst and add a boundary to any skill change outside of selected helmet for a shortterm fix.
How to reproduce the issue
UNEQUIPPING Kitava's thirst solves this issue.
If Kitava's Thirst is equipped (helmet slot) - any input on adding skills/spells/support gems creates a massive lag. I bet this is due to the program checking every dps possibility for kitava's thirst, even if selecting a skill outside of the helmet socket skill tab.
I checked if selecting "full DPS" functionality changes the calculation (i.e. lag time) at all; it does not.
Check coding pertaining to Kitava's Thirst and add a boundary to any skill change outside of selected helmet for a shortterm fix.
Character build code
https://pastebin.com/YphqJT4K
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the lag with the linked Pastebin build while Kitava's Thirst is equipped, then trace the Kitava's Thirst calculation path during skill, spell, and support-gem changes. Done means changes outside the helmet's selected skills no longer cause massive lag while Kitava's Thirst behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100