PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add support for reduced reflected damage taken

Open
#5,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

This mod isn't currently implemented and would nice to have.

Describe the solution you'd like

A minimal implementation would just be presenting the multiplier but further work could be to also present how much reflected damage our active skill would deal against different map reflect values.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Search the codebase for reflected-damage modifiers and active-skill damage calculations, then determine where the reduced reflected damage multiplier is presented. Done means the multiplier is shown; the optional map-reflect damage estimate is described as further work rather than required.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.