PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Active Gem Is not undone correctly sometimes and fails to persist accross gem sets
Open
Nobody has claimed this yet.
bug
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Persistence and behaving correctly with undo
What is the actual behaviour/value?
Doesn't create undo states when changing in left active skill bar
Persistence can change when switch between gem sets.
How to reproduce the issue
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4804#issuecomment-1342740975
Character build code
N/A
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction details in the linked pull request comment, then trace the left active skill bar and gem-set switching behavior. Check how undo states and persistence are handled for these actions. Done means changes create undo states correctly and persist consistently when switching between gem sets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100