PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Eldritich Mods from imported/copypasted items not being taged correctly and thus not being replaced correctly

Open
#4,940 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Eldritich Mods from imported/copypasted items not being taged correctly and thus not being replaced correctly

Describe the solution you'd like

mods should get the {eater} or {exarch} tags before them

Describe alternatives you've considered

No response

Additional context

For correctly tagging the mods from imported items, you would have to parse that in parseRaw?
from actual import items I guess you do it in https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Classes/ImportTab.lua#L834-L841 but for copy pasted items that are like "7% Chance to Block Spell Damage (implicit)" and not "{eater} 7% Chance to Block Spell Damage" its probibly done in parseRaw

could do somthing like

local index = nil
for i, implictMod in ipairs(item.implicitModLines) do
      for _, mod in ipairs(modList) do
          for _, modLine in ipairs(mod.mod) do
              if modLine == implictMod.line then
                  index = i
                  break
              end
          end
          if index then
              break
          end
      end
      if index then
          break
       end
end
if index then

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Classes/ImportTab.lua around lines 834-841 and trace the parseRaw path for copied item text. Compare imported and copied implicit modifier lines with the modifier data and confirm that matching Eldritch mods receive {eater} or {exarch} tags. Done means imported and copied examples are tagged consistently and replacement behavior is corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.