PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Critical Mastery Bug with shock effect

Open
#4,861 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

When clicking on Critical Mastery, and selecting "50% increased effect on non damaging ailments you inflict with a critical strike", and I'm at 100% crit chance, I expect my ailment multiplier for shock to be increased

What is the actual behaviour/value?

When that same mastery is allocated, it changes no values, even at 100% crit chance, for shock value. I was at 3.75 ailment multi before allocating the node, and remained at 3.75 after.

How to reproduce the issue

Simply setting crit chance to 100 and allocating the node with a shocking skill equipped should be able to easily replicate the bug

Character build code
https://pobb.in/fSN3jArINEjk
Screenshots

image
image
image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the linked PoB build code and reproduce the issue with 100% critical chance, a shocking skill, and the specified Critical Mastery allocated. Compare the shock ailment multiplier before and after allocation; done means the mastery increases the displayed multiplier as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.