PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Can't add Brittle using a Skin of the Lords with Resolute Technique

Abierto
#4,341 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

When i add Secrets of Suffering on custom modifiers to add Brittle on ''For Effective DPS'' table, don't disable the Brittle option when i equipe Skin of The Lords (Body armour) with Resolute Technique.
The Brittle buff come from boots equiped on Animated Guardian, that is why, i add Secrets of Suffering on custom modifiers.
I know that ''For Effective DPS'' table is for my caracter, but i would like to calculate the DPS for my Dominating Blow skill (minions), but i can't when i equipe my chest and Brittle option disable. I know that Brittle from Secrets Of Suffering only work from critical strikes, but this was the only way I find to enable Brittle on ''For Effective DPS'' table. And i know too that Resolute Technique dont let me do Critical, but minions from Dominating Blow still can.
Would be great if have a specific table to show ''For Minion Effective DPS'', like an option that appear on minion's skills ''Show minion stats''. Therefor buffs/changes/increases and reductions from tree that don't affect minions still would appear on this table.

What is the actual behaviour/value?

When i equipe Skin of the Lords with Resolute Technique, the Brittle option disappear.

How to reproduce the issue
  1. Add Secrets of Suffering on Custom Modifiers box. (to enable Brittle option)
  2. Add Skin of The Lords with Resolute Technique.
  3. Brittle option disable.
Build code
https://pastebin.com/dy4sb6k4
Screenshots

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza reproduciendo el problema con los Custom Modifiers indicados, Skin of the Lords con Resolute Technique y el código de build proporcionado. Sigue la lógica que desactiva Brittle en la tabla Effective DPS y cómo distingue los efectos del personaje de los efectos de los minions de Dominating Blow. Se considera terminado cuando el cálculo solicitado de Brittle funciona para el contexto del minion sin activarlo incorrectamente para el personaje.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.