PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Can't add Brittle using a Skin of the Lords with Resolute Technique

Open
#4,341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

When i add Secrets of Suffering on custom modifiers to add Brittle on ''For Effective DPS'' table, don't disable the Brittle option when i equipe Skin of The Lords (Body armour) with Resolute Technique.
The Brittle buff come from boots equiped on Animated Guardian, that is why, i add Secrets of Suffering on custom modifiers.
I know that ''For Effective DPS'' table is for my caracter, but i would like to calculate the DPS for my Dominating Blow skill (minions), but i can't when i equipe my chest and Brittle option disable. I know that Brittle from Secrets Of Suffering only work from critical strikes, but this was the only way I find to enable Brittle on ''For Effective DPS'' table. And i know too that Resolute Technique dont let me do Critical, but minions from Dominating Blow still can.
Would be great if have a specific table to show ''For Minion Effective DPS'', like an option that appear on minion's skills ''Show minion stats''. Therefor buffs/changes/increases and reductions from tree that don't affect minions still would appear on this table.

What is the actual behaviour/value?

When i equipe Skin of the Lords with Resolute Technique, the Brittle option disappear.

How to reproduce the issue
  1. Add Secrets of Suffering on Custom Modifiers box. (to enable Brittle option)
  2. Add Skin of The Lords with Resolute Technique.
  3. Brittle option disable.
Build code
https://pastebin.com/dy4sb6k4
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the listed Custom Modifiers, Skin of the Lords with Resolute Technique, and the provided build code. Trace the logic that disables Brittle in the Effective DPS table and how it distinguishes character effects from Dominating Blow minion effects. Done means the requested Brittle calculation works for the minion context without incorrectly enabling it for the character.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.