PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add option to use active minion count for full DPS calculation

Open
#4,196 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

I would like to be able to use the Active Minion Limit as the minion count for the full dps calculation but there is no option to do so.

Describe the solution you'd like

In the skills menu to the right of the minion count box there should be a checkbox to automatically use the Active Minion Limit as the minion count.

This would make it easier to see dps increases from items that increase the minion limit as the increased limit would increase the total dps difference between them.

The same could be done for totems and any other skills that behave in a similar way.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the skills menu at the minion count box and trace how Active Minion Limit and full DPS are represented. Confirm the requested option updates full DPS from the active limit, then determine whether the same behavior should cover totems or similar skills; the payload names no files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.