PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
[3.16] Incorrect Damage Calculation for the "Close Combat" Support Gem when paired with "Shield Crush" Skill Gem
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Background:
Given a "Character" in PoB
And a shield equipped in "Weapon 2" on the "Items" tab
And "Melee distance to enemy" on the "For Effective DPS" subform on the "Configuration" tab is set to 0
Scenario: PoB should present me with a ranked list of Support Gem options (ordered by DPS Descending) to add to the Shield Crush Skill
Given A Character has a "Socket Group" on the "Skills" tab
And "Shield Crush" (Variant: Default, Level: 20, Quality: 0%) selected as a gem in the Socket Group
And "Sort gems by DPS" is checked
And "Full DPS" is selected
When I display the list of support gems to add to the Socket Group
Then the "Close Combat" support gem should NOT display an increase to Total DPS (since this support is not compatible with this skill gem)


What is the actual behaviour/value?
The "Close Combat" support gem shows an increase in effective DPS

How to reproduce the issue
See the description in the "expected behaviour/value" section of this bug ticket
Build code
eNq9Wutv2sgW_1z-ihFSpV1ledjGNInSXRHyKLqhZSFt7_1UTewBZjv2UHtMwq76v99zZuzgECCD23tbqWvM75w578ewZ388RIIsWZJyGb-tO812nbA4kCGPZ2_rH2-vGsf1P36vnY2omn-Ynmdc4De_116d6Wci2JIJoKsTRZMZU58KTt4X4LSgsZozGQ_pXzK5luHb-nsZszq5o3HIVfEpEDRN39OIva1PAiCuE5oGLA776_cGGFEeT2TwlanrRGYLfeySs_uhDAEzGI4-jG9Lh_K4fCjI_OpsJOiKJRNFFUnhn7f1HqhOZ-yCRvAvcKMiA1Ynx8dNz_eO3_ie4_jdems78WTBWPhI5DRd__-JHCXscjplgeJL1k-46s9pHKx12Em3BdtpnuyFDzOh-EJwlpQk20nx7hn_k5Nd2FupqLgYTdZ8Xc9vdjqu1-k43knnf0Mn1SNdexfyM1fzcwHOqHAK0g5mMVesIvFI8lTGP6BfmXSnin0Z3fG4koYFaW85O5S0lzD6YWpCd0xDnqWPHLydMTWkMe3LdO03x9kFveFT9gS6U__LiR1uDLXBDolijlgC1UvZEaCwBxFM1DoH3d0Ss29loOPvNOwFe7DjVwa-2QkcxMqOXRl4vEe6pVS6JdgY8hHVbe8pr8EpYgdxYMf0Y5ywlCXLUlXuWhLkjl27ob2XcMxmzFLTG8aC-TW0wzFVzC4s141hv3EQa2UcBG4xjm9JcIBxkHDDOM2TfeADzfOZJqFFtYhZMltN5pyJNdrtdPZas0xkZdUygWVAlEkO1PxySdNyejnd_doYuF14MGieQBCyjWHgJ1KMEvkXDkDiMLJeEsmsVB2drrNXbYO30no0X6U8gBasB8oxC7PgSf062e2KYpYbyiWLIDP0JAijbTno3-yiPhcwF2_o77l7tBJiG8lukylFg68XMpxZW1kfcjjFJFssoEZgnNnSXfEETJ3yUv9s-BboDzD89-nCZlDCZLQ9YI22PuCGz-Yqhs3K_pQNEntd5lSmm8d0beDWR1xlQlgNoJOv_ClS0TvBTkn7wZl2pw7t7M4zeQ_CzHHnTC2ysoQe0vUc4-3UIGHx3ytr_k_gVgdcxmGWYHRbn7FJ8fyYs5beyfFpEC1kovTLPhVBqlkO4kWmSKwX6oinwZe7bDrF3bkORyR64b-8urrs3w4-XeZSlElSdNaXOIvucA00_8UV3CAnTBc6Ekgh6CJlsHZPqUiBNw9zR0-gvgfKCg8rZL6S26ChfwcJByPagHH5sxJZL-I2SNyQrYDgFSqYvcFuVwuGEZDa2iwvmDZovdpaIc0uaqeg3nnt3MACurJCPo40VuhLwXpcYP-0s9oQEsG0Xjs8NMKE32XKMtr0WmIlB47oVgqWx1DL7LAD5mORlRD53GiDzXuNXVDCSGLttgs2ZRDulmmvy8kt_crivFgWhfFM51pKUqiY1yxKz1fQka7QvBs3JE8A0KuSDHiHbEozge__zKjgaoUlvPT2xlyQwi5M0rm8x-nGsMHkTsHoNzfmm55QOQc8o5DdaIYC6tvPnp4Q9Wctvr4C5XEgshA22rzvPuot6B2eXSczvC7tyyyGPhJzgVe82GjDQokN1sgVD351BqLk2Gsh76hw17zXepUBTsFSd4sBVjIdqf0kS-d18s1oONAFQJsoR45oorQyMxbht0OmaEgVbQ0UWKOFJmlp2eBpG0dt9Q2tHhmvTRUYG8AT9jQc7gsBSc5PEw15rC-xJ1kUSXD_COqqomlkIu3nmMUEwkTQdA6t9zOjC1wTfsxAj8HVFzJlGLxU7TXRNntoWlIQb7XHGKRlRaUwftEpZTIJH28Txgg1IaW5Onkow4fy9T6q0sYATBVLVnkhxpCNYS6BB__42PPqRAG70k8LsKaaXw0MuXHKZQi9J3yPdLmbPo5v9MOruVKL9LTVur-_by6omsspe4ClsRnIqLUANiBlQyvawINaPfhzPuvpP5pRq-B0Zn5-SAvNQRutOKqLD-8lNAb8Dl8WH7QxPnF2T1IGk8p8ohLU8G8po_9o7TH93zGqhnTxGEj4bV47vLx0wCRwwcFCia56hQsR-O9ibjzT0ZAbHp8nzLg3SxnURxmHJtD061KFQSgMkwmnGA6eKZl5ERjDa7U6JR_fD_78eFnrsRlPSS9LZEJrMHBECyy6_wLbE5NJNdNHTgnu1fmHc5oW15wcB3ynZtpYTnJKXM-vlTvbc4JPRrpTMkoYcZpOs_30ldf0y6_6WQJ2UjUzdLKQPH7jbZc6L74gSruWe_mUnDfgb037Ycy-nZKuW4MhTvCA47ft2j8wkc_Yabvpf__FaTfc9q-vsRwnDMQPCcwiOIhQQUz3IfdczYlZpYnJldo_udVPnd_c72V2x-2G037Kz9iS0BhYl823ZuI9YeG1242OLY8jp_2aKEkotJq14KZ541SZ1o58DYjoA4-yiOCaW_q-dtR9TcwAiijdykvafR-zhWAxT-csfXoyuVuRzmsip4Vs93MWk5XMNnm4v3n7ubh7uGDywq4zRusQbSO8UPGLSM8rxk6E-yKiWPV0Qd6SVG7BaGtShUswHPQBcgUFHK8_ateweI35Aurs0zh3m127OHfLLLZG93UD_paiu9MtR7db9t6R6xCcZcmM4jxEpjIhjAZzdEK0InOu0AEmtEtB7X4_6nQOIDSiAexalzFQN-9pTDtYd1fiuNpKfLrayD_ImI0MLK7j8gSEIHfaGJ35_ErGVIHRy2yOIGsafvvXcqSj_LUjzy-_20jANYMxm6InUvLLG6dxAow2ZEAm-qYzVxq6Ws3xn6fO3mDrvBiO3RcRx88CdiJkseybNkEwaJUZOIpFP-8qezpKuXls4elM7umC9O5WaQpGMR4n_vqgdiH5FtJNMteObD_qXEpwVzWBtunyglDnTKgDSa5g1vlKPCuR3G0iedXMa2cE9yeRdaoJ2a12Wre6NavE0wseeMdExNShB22JpG6Vc14IP9hhlnhFeThjr3oWOVXO61SLBada5HVedo-NYQ9luy28KipuVXf8CvJUqIHeS8eEq2K2O8x9261cKb78KkRWKWnjiEp6-pXN6lbwe7daJnnVwtc7PMo61ct-hZh2KhvfswmIjg2ogtg_MPxYevLZXGnthW6FqKzuhh8IF9uSjLSWWWMPrWC5Ma6fbpUS41Y2b8VyYe_PKup4FnZyqruhU9lafhVtbPKlepC_IFIvysSW3mZ2TlgZ9eWpvrPUP1XLeMpnz3-rxm35Ir9mWv_y3C5-x8mpzlqb_5P6fwEiw69d
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the case with Shield Crush and Close Combat using the supplied build, checking the Items, Configuration, and Skills tabs; trace the support-gem DPS ranking and damage calculation. Done means Close Combat no longer reports an increase to Total DPS for this incompatible pairing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100