PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Deleting non-empty folder results in bug

Open
#3,754 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Deleting properly folder

What is the actual behaviour/value?

Trying to delete folder which contains something (there is no possibility to delete non-empty folder) getting error The folder is not empty. After deleting build inside and trying to delete folder (now it is empty) again it gives Couldn't delete $PATH: Permission Denied. After restart PoB folder is gone.
Knowing Windows issues I tried to run PoB as Administrator but nothing changed.

How to reproduce the issue
  1. Create a new folder
  2. Create and save any build inside folder
  3. Try to delete folder
  4. Get The folder is not empty message.
  5. Delete build from folder
  6. Try to delete empty folder
  7. Get Couldn't delete $PATH: Permission Denied error.
  8. Restart PoB
  9. Folder is indeed deleted
Build code
Any build (even empty).
Screenshots

image

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the report. Start by reproducing the folder workflow in the desktop app, then locate the code handling folder and build deletion. Done means deleting a non-empty folder follows the intended behavior and deleting its emptied folder does not report a permission error or require restarting the app.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.