PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Triggered skills are still affected by attack/cast rate modifiers

Ouverte
#3,558 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

bug
Langage dominant
Lua
Étoiles
5.4k
Forks
2.4k
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Modifiers to attack/cast speed currently affect DPS of triggered skills. As far as I'm aware no triggered skill is supposed to be affected by them.

What is the actual behaviour/value?

Skills DPS is inflated by increasing attack/cast rate and takes a hit from reducing it.

How to reproduce the issue
  • Add any triggered skill, i. e. Vengeance, or a spell supported by a trigger support gem like Cast when Damage Taken.
  • Include it in the Full DPS calculations.
  • Increase/reduce its attack/cast rate accordingly. Watch the Full DPS readout change.

In the given build code you can edit the amulet and change the cast rate of Arc via the custom modifier added to it.

Build code
eNrtPWtz27ayn-tfgfFM76Rj2SbAt2_SM_Lbqe0olpM0_aKBJchiTZEKH7aVjv_7WYCkSEmkCNFOes5J26krkbuLxb4XBKHX_3ocu-ieBaHje2828Y6yiZjX9weOd_tm88P18ba1-a9fN153aDR6N9yPHZff-XXjp9fiM3LZPXPfbNqAFtHglkUfM1JqD65NqBeNmO9d0D_94MQfvNm89D22iW6oN3Ci7FvfpWF4ScfszeYnJ-qPNhEN-8wbHOTXj1w2Zl5EXSeMNtGYOl7X79-x6CTw4wnwvYnuHfZw4Q8A9uyi8-7qujC44xUHB-Z_et1x6ZQF3YhGKIQ_bzbbIAN6y04dIH9P3RjoYF0zLGsH60Qn2ubuSrxDOoa_66F2J4wNcpTvA9YJ2NFwyPqRc88OAic6GFGvnzNOdqwqzPWhL2I3ciauw4Icowr-dIk4VpQq4GsfLOGw011P3s_B8nOzqOQKbHe074IW1h7j7NZzIlZEIzZWrR0NG8Qy9Rq0BdNTbcvQduAvtlZxujwmtlSLGDs68Iuxvgq34zuh7zUW5doTPfDHN463IFgpbjPM9v3terwe-L478B-8XO07xKiEvqAePfDDQuywKy393BmyOdhKgzrqysFdgf7lIDmfHRZAcI3kEDizayF0o9zZVbVSL1fsSxES63YV5CF7LNg2WUFwDhJXO5uXT0PXrBUEi5ArObz3I8h5ctLMpWPq-opg3t_j0GdeP2eBmKsIf_ACFrLgvpAFVg0xj5LqWCb4csQrdsu8wjA7q8c5Z6w_OoGkfUWjggAUe0c1DVXRlWo1cIst6L86pgmRceiiyFR1Fd0SiRHTkMNYFBhRdmxNsbCtEVU17FVE5oVnr0iiHLpcdtVJiAYDicjiseB22h05zC3UDJqtrZRuEWtOyrbMOPPTlmJtzbkf3dOw6IfYqJlPAl-cSnXkZJDZAWHAFsqUF8ToBP6fvDJz10NrB2M_LsRSSGsrp53AS826M5qGTh-Stqgxrtgg7s9FOlKt-azIvPDvReku6lMo0HM-d0hl0Nh3obpfmL-xqvR13TIUtRKlHUW0f3foD26lxSxGWR-jG08mEDS4ocniHTsByDp0CvnWtOqB30ErckAnBfOvLm64O0oOkAMvDqCuqHFuR5EHnaL0KAsYS0NVpj4Qqh8uDGNLAC-OUK2N2J3rGjSdGBgrO5gopq1V8tW9c-bxInrjsj2kPBLdIuSmWhQd_wFYG_F2OpRw0QL0Bc0roMrMdxww7-t0kb4cuNQAR94gDrilS4-xiLE8zOtdsd7AP52NJ34QiYsH1O2HguSZN4kj5Im1gpBLvufF4xveeCb_z22iCDl2wn7vJh4O-cLBJjATiGWPo-Pjo4Prs49HKUqXiaiH-r7r0knIBm82PcfdRM4gVXMXQn0_koCGLjdt1-phIZP3AwfEVw_K21MJVsUKQT0cb90lwEAP1GWyIrqeThjXeCgnpTRU1sOKhlsCLmlZZaYl-mIZobM-nUrAzYoYCdgjl7Udl6dLGTldgPkmeVYGGlJe4NzEkZRFiU5FggNenUtMq1huSlm-DFha90gMn9aF9ZBpHpExO6g2JFV0yIYMjFnKkUVwuKZ3zEvDXhbiXgsvClEIse-EjcP9KeSWYy7QQoaauwkZJ4ghqg3YkMYuv_4-pq4TTXmzUrx8nqzhEgwERv4DL1gSOtxnwzebl--uLtrnyc22G6VU-DhvNofUDdMlVcGgWJpti8JPfBfs82U_5Hh9Nx5AQ5tym7Hn0hs--ia65Uu5B37sRalAmMcz5iADDF2fV4b-YIqyindhMD4OZ-Wn18Bcin7i-jfUJbPR8rkW7-N0SJE6zmDIj5S67aAPYQj8Fn1JpnwmvF6ILQXt0CASq8-3bMzvXrCIDmhEd88iEM8ul9GuYA0-pSRn1BI1LEyyn8xf3RQZipfrCS9IYIoxLxxPLLC3b0LfjbkpXbPxxKXB23iQJZZSCYgZygogtYIDCpWSVzTLUmGsmv7MnKpprRIFLoqCk0API-ahhAzKXeXl5gyiph7rxgFfVW082zIq0vNMkFGC_cIa9b0ogNDDBocMCp6soWuu1ZX05DU7I4OKdF527rMmo8M8FgX0mVNfSU565jMqqEjmZSeeeEv7FqJZCLWVw-X8jImvJCc98dPpxI9GLBg7WQ2RxMrabIJfLJt8YnQCqRiXpBK82VQD6QCZCk5ZQN3Bu-H1KPYGvCNZV-xp_qiis0re1py8BQHkD9GMxFxC6cbjse-xQQdq74iG4-Y2uCCBH8j7ymfeHgzYYDZS9sCueWpZRU4-x3AqKJ9_sTF9uanPHty_jNJXkpOe-ozKt1T6f0fMfbn5vvNCl8ZgTe-8rkunYFLdEd-jMYDubzx9xswlCUvL4MyDdvSeRi9u62deP2AUOjq-gsKXzbvQcd_xBbDGc68luTDrpB-rmHZKCmW0UEbs-dk3HVci_aaQMt3ci6Xg7oQGdy_Uxs3TWml0SlH8Kd53zbj_491bRbL9X2nfKnT6Y_Rv_5SQ_1QT_0HVxMq8-o3Kib-xa1gx3VVtg2wJkax3f48F4RcrIT6BgoPuBIyd1RYSqlw_Px0EfjhPcZXnkXnPKyB_35rC9_jGJ4hy4DLi4dPzkk8VsXUyz4wGSon8k3NfbvLZHqBrf-b0z5j6KmrSE8-IoMjPI9E_xfMPU2Y8M88kklkvzZwyd8yib5lhZotSnxi981gYNl4prqbUYIVsRuMf93rGpPkmuq7Ht5s11OkSgTWyhDtACer3KRSOoTKJ9v3xzQutuCzTk567QEUC928rUEFM93zB7hsub435jqU6YZPVwp6jIS3gFO27VqDH8J8znD7XumbRY5GevHWliHLz0-TbPofXcdQVG3Oe1_GVUpLPAuMJ3136wz8O-xvqjX3fj75p0HgfO_27k1i8LvIyC-MRYy5gNUi-Oep_mrg5xmqBF0LfwlOSNdyCB0y-kf_Eh7prmaYg17BwSIm7IOyU-traERSQIIGWOcwDfmGQv-2JUuNs-wJ6zHZonPXZGjpc29Hmhlm7l5ptAlnk8tsn7h94G8SPtnx_AG7Ml9bFA-bndHaldOR7nwQ9fdC9GJXST2J79XXAGKJJwBCoON3VDF-Kx1FwlgkPL2HEgmm6-_7N5l-6ZWGjZWhEw0_AgT_gO6dNG1stXdM0s0UU24K_qkLMFiYGVluqYel2S7NUg7QwNuAz1hVTbWFNIbilabZhtixbs1rYtjEAmkTHLUAkSsuwNbhANEtv6YpGSItgS4XPuqmpLc0GXlqmrQKmZdtKi9iqDmQtbGoAQoAZXVdVQLJNTFoGfAHGDd3gdGFMuGDqLayowISiGgYMYRGDX9ZJS1NtkwOb_LJuKjALw7RaBL5YHMSwWirRAFXXbUDSNKIAkm3yMQ1gTgeOxIxUu0WICTcNwqdrKCpcV03DBFQhSh1okhZ_p7almyRhAKZETKKogl2QmmpiTfBrgjRMmAD8ATlamAtDxUQFMfBpAb8Wn4bBJQXiaWmGjRXBL5c9MAn60TWjpaqaaXNtaLqgq4BODJgN_wzzA8WBCDWYMkzBEIPYOtenxiVmWQZgAQvAjWIBfQKqAT1h3bYFBUFHE_wAHZW_nS2uA4yGLaBsGzqfg00SeDE3XYMrCsxcUxPl6AYMrsJNrGi2IGYpMCGYUssA7QhBwWdsmMCUZqgwIMgJc91zg8GazfWtYiBpqCZnDRNufMTkgygKn4qhEGFIKmdBgb8Y-NbBfDHmfPM5mDAFglUFLoBS4TOxQdPExsI-LM4GsNACotYmisC7CifDYCM99IV7k5om5iNoVtjgkntOGow-XJ2LDz-NomgS7u3uPjw87ExoNPKH7NFx2U7fH-9OgAw47baIQNt8oN02_LPfvjho75vxh2H0h_X1-PjPXmwZDjl_Fx-RR7rtnd1fXX41nWtTu715S3_Hj50_Pnbtce_h5v2wfefH_S_uSS8adsjBlXK0H6r7bTYIQvrbUVc9dnz75DN7ux3YExL85l_3B-6N7v1xqWEntu5-D8zJhaf3Dy-Pneu2qk2-vP_6qTt5GIUHj73Tr9rF8OSCxh_7VO040_6Ho98OHqfY7rzv3X-4_HR-fd7pPl4fmN2bU3yu219-__LJGWqdm-Dtn5P2WPmD_qFdHSpx_FvnCx4NPf_9Z4b33x4a5FwxPnWos309vO9-PT2ACe4P77XfOgfK232tc3Eyfry-_PxADjpdbzI0OqeXD2-EkHczKb9OTtQJE5Gn30Qk41rCBsQYqNOiJGqnryOWwGGIYhJwBkQsTQZO0y1VAg7Mz5ahp1mGacvQA1PPwTCpguMBKoezq8AgTEpNV9U0ueli25KhRzQbywwLsUhmWBUbcuwZkK0k4HQd2zLWAoHOkoHDKjZl4HhayMGsymENyyIy7EGss6XEDHFXhp4CcVhKHYrMsKLeKBgzrp6HakupF8zFkFEv5FoZM4CcJDWubdqmDHsW5GMZOF4AFeSywpwh3UsFNVXRpeCIZUkFNVOzpOzKtmypcQ1DZh7YJFguSEpHIVMuKWhS42pg0TL2omMIkzLzVXRVxs-hSFOl7F7jZ_XIhDXDkktapiE1D4INqfiCgaAMnIYNKbuCvkYGDNobGfdQDVsqTPIiXoYclOQl1gLdX17wwBdo9ERPyDtB_uHSj5i4xy9mX0Sf-NFhDyhkNOiPoLHki1NffX_8mUdWsmNAkIci2tQ1krwye8podEEnWZvKQc9nTwTEC7cRjQ4d6CQD8ZpwEfB3XmDsQOltQWukqZaW1CGvRa-ctqv8c5clnW8csi7r-94gebFJXM6WMAUSuqeBQ9PtRE5efV_B5Wi6hz5cnr3_cLTRvvVY4A_QJxZGG2fjCQMkvl2cDocbHxMKe6gTMATz3VHySwdxAJOINpIDEdgAze6QRTLpa8RwR9lIFbGH9rdn_24IIV2xL3vIMDiy6_QdDkM2_konsYefMPkZJWcF8L0g4q1slJztkj3HfRhBp4Ae-JvSfCWApsPPaJAnbD2XBn7awmIvCmeZr61R1y0sKYlzYFCyAsrXN4qDb5G1EAPq3bI9ZQf6vKetV5ayjYnyC6dw5kUA69xyE8rA8NMrVdnWlV9-5uur6eb_xZWuHLg9GITolb6NdUHxFVaAvAbkF1H4XcFauKEpRdrgDcy7jUYI1BY7gdhCsJHiZHtjWQga_7lAM3nnnotfeOWFP7jiDCHBFj93zxaxiofVzHMXYXBy36i5n53VIpaacpfgt3CpG1yPGLoe8ZWhw4De-l64ceK7A-ahCxrelVvwybb4t2C9ql60XiWX99YrYmyrXDsgT674fNNFLpNw47MfB4g_HMik36ceEntW0Q0_ycSPUHJmRQIpHvcXIJN7M9BjmM1XhnwA5MuGCc6SgjliCpkhihFXSReXS3cx4Gilkj73A_bA6D3bACHcAjy6AnbG1HHn440qH2-WCK0TcbR5nZ3SEBkoRcq9UE99RtvGSuoz2rZq_IJmG9Ryh0kiSlhUv7VNtF8y5efHcxTclyjbxrz7Juuui6_wpPGrSBzr3PM59TF9dMbxGCWncKDkGI45MxSjFEH58R8LEAvE-MkfRUG8Sk055zTRsHjSILLV0I-9wrApg0WM3P6z0JQH2MJQwmQvUj4KnoIoGMgr09i2gGwxxs7GrMU0LcAsj0J6Yr6kJsaoNfe1mvsvFONWzMCqoWDXUpg1SpWhAK-ItAsVx1X76mhjzjRR8gxv4xgclwUuC0PUddy77PJBQIfg6nuIl0kbEBSGzuMemr3dxk3XmF3OzUbBT-c-eMwMsHgoTXqaoz7DqwY1NrrxcJ62oVlP-SlpegmAbT4Vjh7TliEsTX8qpnBzZbQqRCpTKUYqXPQvso2NOf9KyonUt7Y0vFQ3bKl6dcAwtTlfnbu3ZehL4WNLVUVmEwmpkOS3iJZc5wKpy_7r5Ra9NLecAKn_g3I4_P8QXfg8wsRjkOAtP4RHPPdvXNLOEZFUmG5VlAOvsAH1ljUfEpMXGxD1BtXhW0-TBMhUlAkFkRK9SCw7ihGJk8AqoisUgCYQ688K4rS4WI6nAhorvF5cBQ9F-hwXaUqkycPLFFxMb-ywsDRuvyL6tjYvmBoq9bZUeZ_Uxj-tFkJ_RiWq18bHxN66PsSsgAXp17XC4hqRMDOajwwaI-BoKbzhQuwriWy6Zj_lZ1SWRE9i2cXgqMs6kmHOO9L68cku9ZktYlfELbM8bqnKCicrV7JRGqiOpkyUS57n90U8PnD4iYQMtcexy6Li3K2FjrifaP-p7YKWRJPVDkctlOx_5dGjG_nBeOOviN6Ge39Cqe26LJj2aFZ0PhUrRyOrS2f9HKdwyB4jxvldosKyuu0JK2WRYObGEKnMUjdOGuzUiTf41msE3edc1yP2Zk_9OGtooEMRb-yl3Lig0ifyM5dfEUscvgfjQP3Olb4w0F_9OIz88dPsQ261mDy9gtCmcHYDfu6tCMZ9JPaJZ6pdP4bg-giCyVydVmY-Zqn5fPbvhP1wD2P8JMuNd970cdl45kuGUuPZB_WA2oHYrDWstx2eD7ZEQjBKu5oF_GDmQUsESEU6a0Bi0YtlSUDHo6UkSpcquNNndnEYJ-_8cnllxzci38tTWqW_zOddrMwl0qTjTomgiDtFWSIdQi_PaH-EoumEFVgQzjKClhpQhqBtnh6BqWjExknXv9hu5QsLDVugGYT6LVPoDGJFEiWlDiJiIOoyEGC0ce1P6FexOACuQW9jtodOaXDPFzwLxZqxUF3XWk_aLaurbEcqCidElpf26mwpWTVQ6xb9JMgsl3aJcSydIwWeHvqIj8VjB0WhkPMsYCdrVXm8zgZYopMV6UJPITp1osyF0IMD4ahkNfM4YF9iEMw0SRpEV5YXswQjy0wD-TDn6lsUjC-0JGCsKBa1kmJxn7nchinf2ofEF4naUFtsmfFTRfu73FobOShfFrJnNV5WPxjLNWNeEmrLNxcOA9cKHqlZFf3uVtoklNR5erGWgTqOVDe5W1pJoaibSytfWZFYVTxKL2-vbnCdZO_Jso4P3JhvQERvuQdvdMc8185fK9d5celyKLIC5K1LX5xN3o1vXGfMuswLRTrrrcYSw4iRO8kWrPAEwCIuMnFV75U0A_X4oKcEvRF21kiIO-q8mJIHKXuIzoj0Up32ePW4AMw3oiGx33wPqZVtR7F64kvBKkrZSQYL527zJRihqXkYdBuI9YS5_mXOAlfgitCbEtjSyxsUWXQsbP-iychYnfMxjBLEORTkQGhPbAzNjKzC6K1amz_nJ8U_2-b5rwCEIqvJQHcCJxwD2_1TRoOoV2PgKdKhH0yp54TnLAy5Uy1Fu1qjhs6rV2vKbhZxeoMkxVebMybFEmfuUYe6YM-YVBo0KdNxspSe8pg9LpF3Af44d0XVImuNwhjzfrXSGlPVZHVHoqFq8NxYKkFmFoKEiVRYt11r3Rds4IAPPte80xf4eAq_96c9KZw2FJqRPyycKNHAZCESkGbxP-8YSa3NJ5beE019D0rNHm93erQ3EsXeCg8wpB3AqLT_Shugc_a_lvkrlWsjVLxpAFdvpjBAUs2u5w_t-XZcOqfIBXZhNby8LtpNJfTMLpEwzKrKB3-nyufKj6AYhTaZL6mKTQvPqny0ZxU-WjO_SRdhs9KrznWSpq4X-b0bvuGlF_JnQ_Wp4_tUQnh5Q87csyvpqgSXrgFJo5Pm9ZAi5zbc8tC86VX4gvK9ckYb2ncoV0aQd_N7axZTzw38zyn969MGE7G05w97nu9tC5vndRNNl-7-2_NG8lIaj8WXML3DdHqzlcnvkjUqHvFWp4_c6FDB6iRKsTl36bp-9ttO-dHu2cbP7OenCkDZ28KzLeAlMHwFpQChLUNkZwPNYJZB-DojKmwxJiXjFA-yy-C0ClK4hpR4m33Gj74MkjwVyGGyRaZ0N2nlTtLibrkycXcf6AS1b6ZhSDNLRiV7fstQF9GIHNqSgpdF0ZChsrnUMMWNZU2UY5eGd0iVYomUsaQ2E6-cEMgLoWnNmDSajWY0lyauUXCZPdVoIIkP6w5UYklGk3FqzK8qBEpQVpu7EW4yE62ZMeBmpqfV62c5LZSIdl26ZQbWcOZSkUdvwE-DKKjWDTPLfmvqr1zKjQxMb4Ik5ZRLxUGJIhrNU28sVtJA70YzV1Kbma-6vpVpzQN_A5vGjYWvynimJgPUgO1nlD-SmmyuBaOBVTZXwzPMRTYkc1xJr5EHbSC5ig5EIsSQxuJtGC7k9bnUKElMR5WQE14tp1Vq0BpLS28S_2X8ZbkTlLbyGp6qusjdtI0UL1SK1z_EzzX73tC5XfoVZt5linMKxWY9cSD0je-7jHrpq5DLP9wM3enCz1jXYcwGEcuJbHDF-DZXd1qPyfj-kLNw3-fn6GY_Ed11gjhcNYzYVXIc-F_5YbTSzAmsC_9eVgjLP7Vdh0SF6fHDzWJXPICd_-nr9sejq_bJ0Soe-atH8tJzsl9HyH4mQZx0XofFn8dfsVu2PndCgun-Tkndth_4Ub8wQHpKZvaL4XrtOOkvR5SN83o3s_bXux0ajd4NxQ-Ywyi_bvwbDNFuhA==
Screenshots

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Reproduisez le problème avec une compétence Vengeance déclenchée ou un sort pris en charge par Cast when Damage Taken, en utilisant le code de build fourni et la vue Full DPS. Suivez le chemin de calcul du DPS pour les compétences déclenchées et les modificateurs de vitesse d’attaque/d’incantation ; le travail est terminé lorsque la modification de ces vitesses ne change plus le DPS des compétences déclenchées.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
lua
Domaine
backend
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.