PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Ramp Time in Side Bar
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
I'd like ramp time to be included whenever the calculation mode combines hit dps with poison/impale dps. It's important context for the final dps number that players can miss when talking about X bajillion viper strike dps.
If the box is getting too crowded then maybe replace the "total damage per poison" stat, which doesn't seem very relevant when dps is concerned.
ramp time for poison dps = poison duration
ramp time for impale dps = max number of impales / attacks per second
Originally posted by @Sectoidfodder in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/158#issuecomment-594084168
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the side bar calculation-mode display and the existing poison, impale, and total-damage-per-poison stats; compare the requested ramp-time formulas with the current calculations. Done means combined hit plus poison/impale DPS modes show ramp time without overcrowding the side bar.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100