PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Node Blocking

Abierto
#2,844 0 comentarios 2 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Is your feature request related to a problem? Please describe.
It is not related to any problem, just something that I think would be helpful when creating builds.

Describe the solution you'd like
The solution in question would be a simple interaction with any node on the tree, possibly through a right click, that "disables" the node, making it appear with a certain visual queue showing it is disabled (possibly crossed out with an x.)

This would then help when creating a build and looking through Node Power and Power Report as it would exclude blocked nodes from those reports, making it easier to exclude nodes that are calculating as high power nodes, when they actually provide stats that are not related to the build you are utilizing.

Describe alternatives you've considered
Another option would be to create some kind of filtering in the Power Report or Node Power to exclude keywords or something similar, but I think blocking nodes would be a simpler solution.

Additional context
Here would be a situation where this could be useful.

I'm making a simple elemental ice shot bow build, and when using the Node Power Report it is suggesting Command of the Elements as a powerful node, while it does add elemental damage with attack skills and resistance penetration, I know I don't want to use it as I won't be utilizing a shield.

It would be great to be able to quickly right click and choose block or ctrl + right click or some other shortcut to make it so it no longer shows up as circled in red and is excluded in the actual Power Report.

PoB Node Power Blocking Example

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza localizando la interacción con el árbol de nodos y los puntos de entrada de Node Power y Power Report. Implementa el estado visual deshabilitado descrito y asegúrate de que los nodos bloqueados queden excluidos de ambos informes; estará terminado cuando un nodo pueda bloquearse y desbloquearse mediante una interacción, permanezca marcado visiblemente y deje de aparecer en los informes.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.