PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Node Blocking
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Is your feature request related to a problem? Please describe.
It is not related to any problem, just something that I think would be helpful when creating builds.
Describe the solution you'd like
The solution in question would be a simple interaction with any node on the tree, possibly through a right click, that "disables" the node, making it appear with a certain visual queue showing it is disabled (possibly crossed out with an x.)
This would then help when creating a build and looking through Node Power and Power Report as it would exclude blocked nodes from those reports, making it easier to exclude nodes that are calculating as high power nodes, when they actually provide stats that are not related to the build you are utilizing.
Describe alternatives you've considered
Another option would be to create some kind of filtering in the Power Report or Node Power to exclude keywords or something similar, but I think blocking nodes would be a simpler solution.
Additional context
Here would be a situation where this could be useful.
I'm making a simple elemental ice shot bow build, and when using the Node Power Report it is suggesting Command of the Elements as a powerful node, while it does add elemental damage with attack skills and resistance penetration, I know I don't want to use it as I won't be utilizing a shield.
It would be great to be able to quickly right click and choose block or ctrl + right click or some other shortcut to make it so it no longer shows up as circled in red and is excluded in the actual Power Report.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the node tree interaction and the Node Power and Power Report entry points. Implement the described disabled visual state and ensure blocked nodes are excluded from both reports; done means a node can be blocked and unblocked through an interaction, remains visibly marked, and no longer appears in the reports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100