PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Update build search field to not run a full file search on each keystroke

Offen
#2,773 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@Wires77 arbeitet bereits daran.

Seit 13.5.2021.

enhancement technical
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

You can also do it like this to use a changeFunc instead of enterFunc. This does run NewFileSearch for every keypress, though, which obviously can feel a bit more laggy. What you could do here to minimize that lag is instead of having this function call self:BuildList(), it could create the list with all builds, loop through that list in this changeFunc, and build a filtered list that it assigns to self.list for the build list to use.

That latter bit could be a separate PR, but if you could do it here that'd be great. I do think using a changeFunc instead of enterFunc is more consistent with other lists, though.

	self.controls.searchText = new("EditControl", {"TOP",self.anchor,"TOP"}, 0, 25, 640, 20, self.filterBuildList, "Search", "%c%(%)", 100, function(buf)
		main.filterBuildList = buf
		self:BuildList()
	end)

Originally posted by @Wires77 in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/2546#discussion_r617007653

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.