PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Witchhuner's Brandsurge calculate ignite dps

Open
#2,499 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Is your feature request related to a problem? Please describe.
Brandsurge doesn't calculated ignite dps

Describe the solution you'd like
Activate ignite calc regardless of brand type or implement a checkbox of brand type used for 100% Phys to brand type ele conversion.

Additional context
It should calculate it I think. It does it in game
изображение

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file, test, or entry point. Start by locating the Brandsurge and ignite damage calculations, then compare the planner's result with the in-game behavior described in the issue. Done means Brandsurge correctly includes ignite DPS for the relevant brand conversion behavior, with coverage for the chosen handling of brand types.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.