PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Kitava's thirst trigger rate

Open
#2,444 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Kitava's thirst trigger of socketed spells do not take the cast speed of trigger spell into consideration.

The dps calculation from Kitava's thirst triggered spell should calculate triggerrate depending on spell to trigger kitava's thirst.

For example, if your triggering spell has a cast speed of 2 cast per second then kitava's thirst cannot trigger more often than 2*50%

It also needs to take spell echo into consideration. The second recast from spell echo spends no mana and can therefore not trigger Kitava's thirst, if spell echo is used then the cast speed used in trigger rate calculation needs to be once again multiplied with 50%.

So the formula for Kitava's thirst should be something like

"if trigger_spell_manacost > 100 then; trigger_rate = trigger_spell_cast_speed * 50%; if (1 / trigger_rate) < kitavas_thirst_cooldown then; trigger_rate = kitavas_thirst_cooldown"

or something like that, however if the (1 / trigger rate) is less than kitava's thirst cooldown it will miss that trigger and trigger on the next trigger instead. maybe a note needs to be added on that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Kitava's Thirst trigger-rate calculation and inspect how triggering-spell cast speed, mana cost, cooldown, and Spell Echo are represented. Compare the current DPS result with the examples in the issue, then add coverage showing the calculated rate respects the 50% trigger limit, cooldown, and mana-free Echo recast.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.