PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Saving after switching from Notes

Open
#2,271 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Save option occasionally stops working, kind of.

I was working on a build for my next character and I like adding notes for if I go back to the character after a few leagues so I don't forget my thought process.

If I change the notes section I can save right then with no problem, but if I then switch the view to anything else before saving (i.e. items or tree) the save button doesn't do anything. It will automatically save if I then switch back to the notes, or I can hit the back button and be prompted to save (which works).

This happens every time I do things in that order, on any build.

It's not a big deal as I am able to save everything.

https://pastebin.com/vQiQTwAN

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by editing Notes, switching to Items or Tree, and pressing Save; compare this with saving from Notes or using the back button. Trace the save handling for view changes and make the Save option persist the edit regardless of the selected view, then verify the sequence works on a build.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.