PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Make triggers incompatible with each other, and clearly mark them in the skill gem dropdown as "inferior/bad"

Open
#1,757 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Is your feature request related to a problem? Please describe.
If a spell/gem already has a trigger, i. e. if there is a spell gem socketed into a wand with the "Trigger a Socketed Spell when you Use a Skill" modifier or already linked to a trigger gem, none of the trigger gems like Cast on Death Support should be presented as a valid choice, because they will outright disable all affected skills if chosen.

Describe the solution you'd like
Trigger gems are marked as "bad/inferior" in the dropdown like when a gem is a net negative to the build, if there is already another trigger applied.

Describe alternatives you've considered
Other than keeping all this in mind none.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the skill-gem dropdown and its existing logic for marking gems as bad or inferior, then trace how socketed and linked triggers are detected. Done means incompatible trigger gems are clearly marked or rejected when another trigger already affects the skill.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.