PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Punishment Curse Should Be Automatically Calculated in DPS
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
Punishment curse does not contribute to the final DPS unless the "Enemy is on Low Life" checkbox is checked. This behavior is inconsistent in PoB compared to effects like Culling Strike.
Describe the solution you'd like
I think the increased damage taken at half its value should be applied automatically.
For example, Culling Strike is calculated automatically in the final DPS. It does not require an "Enemy is in Culling Strike range" checkbox.
This should be especially easy now that Low Life is 50%. For example, if a player has level 1 Punishment that says:
"Cursed Enemies take 30% increased Damage while on Low Life"
It could automatically be calculated as:
"Nearby Enemies take 15% increased Damage"
Then, if the player checks the "Enemy is on Low Life" checkbox, it could use the original 30% value instead.
Please consider this change, and thanks a lot for all your hard work!
Describe alternatives you've considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Punishment modifier and the existing “Enemy is on Low Life” checkbox in the DPS calculation, then compare that path with Culling Strike’s automatic handling. Done means Punishment contributes half of its low-life increased damage automatically and uses the full value when the checkbox is enabled, with the calculation covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100