PEtab-dev / PEtab-dev/libpetab-python

Mapping table contributions to parameter table validation (SciML use case)

未关闭
#494 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

validation
主要语言
Python
星标
18
派生
9
PR 合并指标
30 天内没有已合并 PR

描述

Background

This issue summarises the question of whether the mapping table should be allowed to contribute additional valid entries to the parameter table. This came up during review of #482 and #480.

For currently supported model types (SBML, PySB), the assumption has been that the mapping table would not introduce additional valid parameter table entries.

However, Petab-SciML requires this kind of mapping table contribution. For example, a network parameter group net1.parameters could be assigned a PEtab ID (e.g. net_ps) in the mapping table, and that ID would then appear in the parameters table with its bounds and priors. In this case, the mapping table does need to feed into parameter table validation.

Open questions
  • Are SciML problems the only use case where mapping table entries need to be treated as valid parameter table parameters?
  • What API would be needed to validate parameters contributed by the mapping table?
    • A SciML specific ValidationTask is one option
Next steps
  • Confirm whether SciML is the only use case for this requirement
  • Design the API to support it
  • Implement and test

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

No source files, tests, or entry points are named. Start by reviewing issues #482 and #480 and confirming whether SciML is the only use case; design an API for mapping-table-contributed parameters, then implement and test the validation behavior.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend-api-design
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
冷清
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。