PEtab-dev / PEtab-dev/libpetab-python
`flatten_timepoint_specific_output_overrides` should not do anything if there are no timepoint-specific output parameters
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
flatten_timepoint_specific_output_overrides's only purpose is getting rid of timepoint-specific output parameters. If there aren't any, it shouldn't modify the petab problem. Currently, the problem is modified nonetheless.
Depending on the exact way of fixing this, unflatten_simulation_df will probably also have to be adapted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate flatten_timepoint_specific_output_overrides and inspect how it changes the PEtab problem when no timepoint-specific output parameters exist. Check unflatten_simulation_df as well, then verify that problems without such parameters remain unchanged while existing flattening behavior still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100