PEtab-dev / PEtab-dev/libpetab-python
single objectivePriorParameters are cast to numpy.float64
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
When all objectivePriorParameters are either empty or set to a single value, the respective column will be read with dtype numpy.float64, which may cause problems down the line as spec says this should be a string. Not a issue currently since all currently available priors require two parameters, but may lead to problems if that changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the code that reads the objectivePriorParameters column in PEtab files and inspect how empty, single-value, and multi-value columns are converted. Add a regression check showing that empty or single-value parameters retain the string dtype required by the specification, then verify the existing parsing tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100