PEtab-dev / PEtab-dev/libpetab-python
Wrong plot_goodness_of_fit if different order of rows in measurement_df and simulation_df
Open
Nobody has claimed this yet.
bug
visualization
- Dominant language
- Python
- Stars
- 18
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Currently there is no check in plot_goodness_of_fit that rows in measurement_df and simulation_df correspond to each other. And if they do not it messes up the plot.
For example, for the Isensee model from the benchmark collection
Wrong plot:
Correct plot:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating plot_goodness_of_fit and inspect how measurement_df and simulation_df rows are paired. Reproduce the Isensee benchmark example with differently ordered rows, then verify that the function detects or handles the mismatch so the resulting plot remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100