PEtab-dev / PEtab-dev/libpetab-python
petab.get_model_for_condition may remove rateRules where it shouldn't
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 18
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
If a rate-rule target occurs in the condition table, this should only affect the initial value, not the rule itself.
Reported by @dilpath
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating petab.get_model_for_condition and trace how rate-rule targets from the condition table are handled. Verify that a matching target changes only its initial value while preserving the rate rule, then add or update coverage for that behavior if the surrounding tests identify an appropriate location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100