OSVR / OSVR/libfunctionality

Handle dlerror better

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
CMake
Stars
9
Forks
16
PR merge metrics
No merged PRs in 30d

Description

A contributor on a related project brought up that the lone dlerror before we attempt to load the library in the libdl pathway may be harmful somehow, and we're certainly not doing anything useful with the returned string when we get an error after trying to load when we could be.

Conversation link: https://github.com/OSVR/OSVR-Vive/pull/10#discussion_r58945956

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked OSVR-Vive pull-request discussion, then locate the libdl pathway in this repository and trace both dlerror calls. Determine the intended handling for the returned error string and confirm the behavior for failures after attempting to load a library.

Written by the indexing model from the issue text.

Assessment

Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.