Request to modify access modifiers of methods in EntityRoutingConvention and EdmModelExtensions

Open
#974 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
api, backend-api-design

Research direction

Locate EntityRoutingConvention and EdmModelExtensions, then inspect their current accessibility and nearby tests or usages. Confirm whether the requested inheritance and public access are compatible with the library's API design; done means the requested access changes are implemented with passing relevant tests and no API breakage concerns.

Written by the indexing model from the issue text.

Description

feature P3

I'm currently working on adding a custom routing convention to my project. My custom convention inherits from EntityRoutingConvention and the implementation is closely aligned with the base.

To effectively achieve this, I needed to copy-paste some methods that are not available.
So I'd like to propose modifying the access levels of certain methods:

  1. Changing internal static (string, string) Split(string actionName) to protected static (string, string) Split(string actionName).
  2. Changing internal static class EdmModelExtensions to public static class EdmModelExtensions.

Is this something that can be implemented?

Dominant language
C#
Stars
505
Forks
186
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OData/AspNetCoreOData

All issues in OData/AspNetCoreOData

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.