Dashboard isModified setting for tags
@jgclark ci sta già lavorando.
Dal 14/11/2025.
- Lingua principale
- JavaScript
- Stelle
- 204
- Fork
- 82
- Merge medio
- 22h 27m
- PR unite (30g)
- 3
Descrizione
When you get a few moments, can you have a look at this?
I have a perspective called ALL_ON that has every item enabled and a bunch of tags in it.
About half the time that I switch to this perspective, without making any changes, I see it think it's modified:
Log says:
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged: Setting perspective.isModified because of changes to settings: 7 keys: showTagSection_#dbwDR, showTagSection_#waiting, showTagSection_@pierce, showTagSection_@kenna, showTagSection_@anique, showTagSection_@bev, showTagSection_@storey :: {
"showTagSection_#dbwDR": true,
"showTagSection_#waiting": true,
"showTagSection_@pierce": true,
"showTagSection_@kenna": true,
"showTagSection_@anique": true,
"showTagSection_@bev": true,
"showTagSection_@storey": true
}
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#dbwDR']=undefined vs. sent to save: cleanedSettings['showTagSection_#dbwDR']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_#waiting']=undefined vs. sent to save: cleanedSettings['showTagSection_#waiting']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@pierce']=undefined vs. sent to save: cleanedSettings['showTagSection_@pierce']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@kenna']=undefined vs. sent to save: cleanedSettings['showTagSection_@kenna']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@anique']=undefined vs. sent to save: cleanedSettings['showTagSection_@anique']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@bev']=undefined vs. sent to save: cleanedSettings['showTagSection_@bev']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: activePerspDefDashboardSettingsWithDefaults['showTagSection_@storey']=undefined vs. sent to save: cleanedSettings['showTagSection_@storey']=true
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Setting isModified to true for perspective z_ALL_ON
JSLog: 2025-11-14 10:58:05 | DEBUG | doDashboardSettingsChanged :: Saving perspectiveSettings also
The front-end is sending all the TAG sections as true (which is correct), but the variable activePerspDefDashboardSettingsWithDefaults is not including those TAGs and therefore they don't match. So somewhere/somehow that activePerspDefDashboardSettingsWithDefaults needs to include the TAG sections so that the comparison works properly.
Can you please have a look?
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.