NativeScript / NativeScript/plugins
[@nativescript/google-signin] Tethered Device SignIn
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 206
- Forks
- 123
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 1
Description
Not really a bug but didn't know the etiquette to share for other people who encounter this issue.
Calling GoogleSignin.signIn on a tethered device results in an error of Error: |presentingViewController| must be set.
Traced this to index.ios.js const keyWindow = UIApplication.sharedApplication.keyWindow; is null since I'm guessing my keyWindow actually is related to my physical keyboard.
Switched to an emulator and everything is fine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with index.ios.js and the GoogleSignin.signIn call described in the report, then compare behavior on a tethered physical device and an emulator. Done means sign-in no longer fails with “presentingViewController must be set” on the tethered device.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100