NativeScript / NativeScript/nativescript-cli

Updating package.json platform versions, doesn't work.

Open
#5,422 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Environment

  • CLI: 7.x

Describe the bug
Basically because we are using NPM now to manage the dependancies; it will store a copy of the runtime in @nativescript/ios or @nativescript/android if you bump the version of the package.json file; it will bump those copies; but the copy that we create in the "platforms/ios" or "platforms/android" remains whatever was their before.

Expected behavior
That I would have the version in the package.json file.

Additional context
We might need a post install script to clean the platforms/ios or platforms/android folder on install of the runtimes, so that way the next tns command will see the platforms folder empty and re-install the platforms from the npm version that was installed.

Possible corner case is if the CLI installs the platforms version before doing a npm i; we need to verify this isn't the case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how package.json updates the runtime copies in @nativescript/ios and @nativescript/android, then compare that with the existing platforms/ios and platforms/android handling. Verify whether the CLI installs platforms before npm i and assess the suggested post-install cleanup. Done means platform folders use the versions installed from package.json.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.