NativeScript / NativeScript/nativescript-cli

Since NS7 update, some plugins fail building with "Error: spawn ./gradlew EACCES"

Aberta
#5,368 7 comentários 2 reações 1 responsável Ver no GitHub

@rigor789 já está trabalhando nisso.

Desde 4/9/2020.

Linguagem predominante
JavaScript
Estrelas
1.1k
Forks
204
Merge médio
1d 9h
PRs com merge (30d)
8

Descrição

I personally haven't tested it on Windows, so there might not be any problems on that platform because the build scripts are handled separately.

Since the update to NS7 a few days ago, there have been multiple people on the NSCommunity Slack reporting this. I personally have encountered the problem in relation to nativescript-socket.io, but it's not specific to it, as it actually boils down to an issue in the CLI.

The problem is two-fold: first, the EACCES error is caused by the gradlew file not being being marked as executable. Once this is fixed, errors relating to the carriage return character start popping up. The issue now is that the gradlew file uses windows style newline (\r\n) instead of *nix style newline (\n). I've implemented a quick and dirty fix, but this only solves the symptoms, it doesn't solve the problem at the root cause as I'm not familiar enough with NS to know which part of the tooling generates the gradlew file when building plugins.

The temporary fix involves editing a file in the NS CLI:

  1. in the global node_modules folder (unless NS is locally installed under the project's devDependencies), find nativescript/lib/services/android-plugin-build-service.js
  2. anywhere at the top of the file (maybe between lines 19-24 for consistency's sake) add const fs = require("fs");
  3. at line 413 (formerly 412 before the above addition) add:
if (!this.$hostInfo.isWindows) {
    const gradleFile = path.join(pluginBuildSettings.pluginDir, gradlew);
    let content = fs.readFileSync(gradleFile, {encoding:'utf8', flag:'r'});
    content = content.replace(/\r/g, '');
    fs.writeFileSync(gradleFile, content);
    fs.chmodSync(gradleFile, 0o755, (err) => {
        if (err) {
            console.log("Error changing setting gradlew as executable");
            throw err;
        }
    });
}

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.