NativeScript / NativeScript/nativescript-cli

tns resources generate splashes are the wrong size

Open
#5,358 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Environment

  Getting NativeScript components versions information...
✔ Component nativescript has 6.8.0 version and is up to date.
✔ Component tns-core-modules has 6.5.15 version and is up to date.
⚠ Update available for component tns-android. Your current version is 6.5.0 and the latest available version is 6.5.3.
⚠ Update available for component tns-ios. Your current version is 6.5.0 and the latest available version is 6.5.2.

Describe the bug

When running tns resources generate splashes image.png the android splash screens are very small.
I tried with different sizes of input image, all corresponding to a scale up of xxxhdpi. Still, very small. Tried with a square image instead of 1920x1080, same result.

To Reproduce

  • Create an image, 1920x1080, or anything bigger/smaller
  • tns resources generate splashes image.png
  • Go to the Android's xxxhdpi resources folder.
  • The image is like 640px

Expected behavior
Images the right size, but I'm really not sure what it's expecting as an input. Bigger files with special names for IOS?
I ended up using http://images.nativescript.rocks/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing tns resources generate splashes image.png with the reported image sizes and inspect the generated Android xxxhdpi resources. Trace the CLI entry point for splash generation to identify how output dimensions are calculated. Done means generated splash images have the expected dimensions for the supported platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, ios, javascript
Domain
cli, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.