NativeScript / NativeScript/nativescript-cli

Nativescript (Android production build) keystore params not validated

Open
#5,311 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Environment

  • CLI: 6.5.0
    Android Build

Describe the bug
tns build command doesnt do a single verification of the keystore we providing (production build).
In our sample the file doesnt even exist were prodiving.

Expected behavior
TNS build should not start the build before checking that everything is fine. Even better it should tell whats exactly the error (file missing, keystore invalid, alias not found, password not correct,...). Instead of letting gradlew fail..

To Reproduce
tns build android --release --key-store-path android.keystore --key-store-password xxx --key-store-alias zzz--key-store-alias-password yyy --env.aot --env.uglify --env.report --env.hiddenSourceMap

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Android release path invoked by tns build android --release and reproduce the command shown in the issue. Done means invalid keystore paths or credentials are rejected before Gradle starts, with an error identifying the specific validation failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript
Domain
build-system, cli, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.