NativeScript / NativeScript/nativescript-cli

ui-core dependency needs cleanup - causing release build issues

Open
#4,118 23 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug severity: medium
Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

From @NathanWalker on March 19, 2018 18:52

With a standard package.json using more than 2 individual ui-* package as follows:
screen shot 2018-03-19 at 11 46 53 am

Will cause UICore.framework to be added multiple times to project for each ui-* package:
issue
issue2
screen shot 2018-03-19 at 11 45 36 am

Causing these problems:

screen shot 2018-03-09 at 8 50 10 am screen shot 2018-03-08 at 7 28 54 pm screen shot 2018-03-08 at 7 28 42 pm

This is critical.

Copied from original issue: telerik/nativescript-ui-feedback#580

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with a standard package.json containing more than two ui-* packages and reproduce the release build issue. Inspect how dependencies are added to the project, then verify that UICore.framework is included only once and the reported release-build problems no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript
Domain
build-system, cli, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.