NativeScript / NativeScript/nativescript-cli

Feature request—support Android 8’s adaptive icons

Open
#3,697 2 comments 21 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature os: android resources generation
Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Tell us about the problem

Android 8 has the concept of adaptive icons, which is some crazy way of having app icons be either circles or squares based on OEM.

Currently the {N} CLI doesn’t appear to support this concept, as currently, if you just run tns resources generate icons with a solid-background-color icon, you end up with something like this.

screen shot 2018-06-20 at 2 35 19 pm

This issue is a feature request for us to generate adaptive icons using tns resources generate icons.

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:
  • CLI: 4.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the tns resources generate icons command in the NativeScript CLI and its Android resource-generation path. Confirm how a solid-background-color icon is currently handled, then verify that the command generates Android 8 adaptive icons with the expected OEM shape behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript
Domain
cli, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.