NativeScript / NativeScript/nativescript-cli
tns resources generate makes some of the new generated resources with different dimensions
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 204
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 8
Description
Please, provide the details below:
Tell us about the problem
After running tns resources generate icons/splaseh and comparing the "old" and "new" icons, logos etc. note that there are differences in some images dimensions'
Which platform(s) does your issue occur on?
Both
Please provide the following version numbers that your issue occurs with:
- CLI:
4.0.0-2018-03-29-11322
Please tell us how to recreate the issue in as much detail as possible.
- Create app
- Run
tns resources generate icons <Path to image>andtns resources generate splashes <Path to image> -- background
Here's a list with the resources with different width and height from the default resources:
../App_Resources/Android/drawable-hdpi/logo.png../App_Resources/Android/drawable-ldpi/logo.png../App_Resources/Android/drawable-mdpi/logo.png../App_Resources/Android/drawable-xhdpi/logo.png../App_Resources/Android/drawable-xxhdpi/logo.png../App_Resources/Android/drawable-xxhdpi/background.png../App_Resources/Android/drawable-xxxhdpi/logo.png../App_Resources/iOS/Assets.xcassets/LaunchImage.launchimage/Default-1125h.png../App_Resources/iOS/Assets.xcassets/LaunchImage.launchimage/Default-Landscape-X.png
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the listed tns resources generate commands for icons and splashes, then compare the generated files under App_Resources/Android and App_Resources/iOS/Assets.xcassets/LaunchImage.launchimage with the default resources. Done means the listed generated images have the expected matching dimensions on both platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, ios, javascript
- Domain
- cli, mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100