NVlabs / NVlabs/RoboLab

parse_env_cfg updates cfg.env_spacing instead of cfg.scene.env_spacing

Open Beginner friendly
#35 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
508
Forks
81
Avg merge
14d 21h
Merged PRs (30d)
2

Description

In the GeneratedTaskEnvCfg class, the following variables are set:

self.num_envs: int = num_envs
self.env_spacing: float = env_spacing
...

# Set task-specific configs
self.scene = scene_env_cfg(num_envs=num_envs, env_spacing=env_spacing)

See: https://github.com/NVlabs/RoboLab/blob/ad45d4f974725d020f82c2b0d77d78533aeba2b3/robolab/core/environments/config.py#L210.

However, in parse_env_cfg, the cfg.scene.num_envs is updated, but not cfg.scene.env_spacing:

if env_spacing is not None:
    cfg.env_spacing = env_spacing

...
# number of environments
if num_envs is not None:
    cfg.scene.num_envs = num_envs
    cfg.num_envs = num_envs

See: https://github.com/NVlabs/RoboLab/blob/ad45d4f974725d020f82c2b0d77d78533aeba2b3/robolab/core/environments/config.py#L374.

This means that the env_spacing override is not correctly propagated to Isaac Lab.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in robolab/core/environments/config.py at GeneratedTaskEnvCfg and parse_env_cfg, using the linked lines as the entry points. Trace how env_spacing is stored during parsing and compare it with the existing num_envs propagation. Done means an env_spacing override reaches cfg.scene.env_spacing and is correctly propagated to Isaac Lab.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
robotics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.