NVIDIAGameWorks / NVIDIAGameWorks/kaolin
Squared euclidean distance in sided_distance()
Open
@JerryJiehanWang is already working on this.
Since Jul 12, 2021.
documentation
good first issue
question
- Dominant language
- Python
- Stars
- 5.2k
- Forks
- 629
- Avg merge
- 53m
- Merged PRs (30d)
- 2
Description
Hi,
In kaolin/kaolin/metrics/pointcloud.py it says that the sided_distance() method computes
For every point in p1 find the indices and euclidean distances of the closest point in p2.
However, it seems like the underlying _C.metrics.sided_distance_forward_cuda returns the squared euclidean distance. Can you please clarify this?
Thank you
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.