NVIDIA / NVIDIA/simready-foundation
SR.001 validation errors are returned but never reported
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 88
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
SR.001 returns a list of errors from CheckStage, but the validation framework expects failures to be registered using _AddFailedCheck, as demonstrated by SR.002.
As a result, assets with missing required SR.001 metadata pass validation without reporting any failures.
Verified with a stage authoring no customLayerData at all, SR.001 reports no failures.
Expected behavior: CheckStage should register each error returned by check_sr001_metadata_whitelist() using self._AddFailedCheck(...), with requirement=cap.SimReadyRequirements.SR_001, similar to the SR.002 implementation.
Acceptance criteria: An asset missing one or more required metadata fields fails SR.001 validation and reports the corresponding error message.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nv_core/sr_specs/docs/capabilities/core/sim_ready/validation.py at the SR.001 CheckStage implementation and compare it with the SR.002 implementation linked in the issue. Verify behavior using a stage with no customLayerData, then confirm that missing required metadata produces the corresponding reported failure and message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100