[BUG]: VMM growth frees an unowned address after a failed adjacent reservation
@Andy-Jost arbeitet bereits daran.
Seit 23.7.2026.
- Vorherrschende Sprache
- Cython
- Sterne
- 3.4k
- Forks
- 329
- Ø Merge
- 1 T. 23 Std.
- Gemergte PRs (30 T.)
- 116
Beschreibung
Component
cuda.core
What happened?
VirtualMemoryResource.modify_allocation() first tries to reserve the additional virtual address range immediately after the existing allocation.
When that cuMemAddressReserve() call fails with a recoverable error, the returned pointer is not an owned reservation. The cuda.bindings wrapper returns (error, None) for this case, but the current growth path still calls cuMemAddressFree(new_ptr, size) before entering the slow-path fallback.
That cleanup call is invalid because no reservation was created. It can replace the original recoverable reservation error with another driver error, such as CUDA_ERROR_INVALID_VALUE, and prevent the fallback from being attempted.
How to reproduce
On a CUDA VMM-capable GPU, first allocate a small buffer and request an intentionally impossible growth size:
import platform
from cuda.core import Device, VirtualMemoryResource, VirtualMemoryResourceOptions
from cuda.core._utils.cuda_utils import CUDAError
device = Device(0)
device.set_current()
handle_type = "win32_kmt" if platform.system() == "Windows" else "posix_fd"
mr = VirtualMemoryResource(
device,
config=VirtualMemoryResourceOptions(handle_type=handle_type),
)
buf = mr.allocate(4096)
try:
# Adjust this value if needed to make cuMemAddressReserve return
# CUDA_ERROR_OUT_OF_MEMORY on the target platform.
mr.modify_allocation(buf, 1 << 62)
except CUDAError as exc:
print(exc)
finally:
buf.close()
On the affected path, when the adjacent reservation returns CUDA_ERROR_OUT_OF_MEMORY, the subsequent cuMemAddressFree(None, size) produces a second error and masks the original reservation failure. The corrected path skips the free because the reservation did not succeed, then proceeds to the slow-path attempt and preserves the driver error if that attempt also fails.
The binding-level behavior can also be observed directly: cuMemAddressReserve() returns ptr=None on failure, while cuMemAddressFree() requires a pointer that came from a successful reservation.
Expected behavior
If the adjacent reservation fails, the code should not call cuMemAddressFree() for its returned pointer. It should either enter the slow path or propagate the original reservation error.
A reservation should only be freed when cuMemAddressReserve() succeeded and returned a noncontiguous address.
Additional context
PR #2237 separates these two cases and adds regression coverage for both failed reservations and successful noncontiguous reservations.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.