feat: normalize trailing-dot hosts in the sandbox supervisor
Nessuno ha ancora preso questa issue.
- Lingua principale
- Rust
- Stelle
- 8.7k
- Fork
- 1.3k
- Merge medio
- 2g 11h
- PR unite (30g)
- 253
Descrizione
Problem Statement
A destination host with a trailing dot (api.example.com., the root-anchored FQDN form from RFC 1034) is treated inconsistently by the sandbox supervisor because the host string parsed from the wire flows verbatim into every decision layer:
- Endpoint admission (both the exact and glob branches of
endpoint_allowedinsandbox-policy.rego) never matches the dotted form, so a CONNECT to an allowed host fails closed when spelled with the trailing dot. - Hostless
allowed_ipsendpoints admit any hostname on the port, so the dotted form is admitted there, but supervisor middleware selectors (including the universal**) never match a host containing an empty DNS label, so middleware such asopenshell/secretsis silently skipped for that traffic. Middleware ships in #2027 (unreleased). - Dynamic credential key matching (token grant injection) also fails against the dotted form.
The dotted spelling is rare but legitimate: in Kubernetes, curl https://api.example.com. is a standard way to opt out of resolver search-domain expansion under ndots:5. It is also a cheap probe for a sandboxed agent looking for policy gaps.
Severity note: filed as regular hardening rather than via SECURITY.md because shipped behavior fails closed (host-matched endpoints deny the dotted form). The only permissive path, the middleware skip on hostless allowed_ips endpoints, exists only in the unreleased middleware feature from #2027.
Follow-up from the #2027 host matching review.
Proposed Design
Normalize the host once at the wire parse points, and keep the original string for DNS resolution:
- Add a helper in
openshell-corenext tohost_pattern(e.g.normalize_request_host) that strips exactly one trailing dot.example.com..still contains an empty label, stays invalid, and stays denied. - Apply it in
openshell-supervisor-networkwhere the CONNECT authority and Host header are parsed into host and port, before the host is stored in the connection context.ctx.hostand everyNetworkInputconstruction site then inherit the canonical form, so Rego admission, middleware selection, credential matching, and OCSF logs can never disagree with each other. - Resolve DNS with the original (dotted) string. The trailing dot's one operational meaning is "do not apply resolver search domains"; stripping before resolution would silently re-enable search expansion in Kubernetes.
allowed_ipsand cloud-metadata SSRF checks validate resolved IPs after resolution either way, so nothing is weakened. - Do not normalize inside
HostPattern::matches. That would fix middleware selection but leave Rego admission seeing the dotted form, recreating the cross-layer divergence #2027 eliminated. - While implementing, check any CONNECT-host vs TLS SNI consistency logic: RFC 6066 forbids the trailing dot in SNI, so clients may keep it in the CONNECT authority while stripping it from SNI.
Safety argument: api.example.com. and api.example.com are the same DNS name, and a sandboxed agent can always send the undotted form, so normalization grants no new network access; it only removes the inconsistent treatment of the dotted spelling. Precedent: Envoy's strip_trailing_host_dot, and nginx strips the dot for server_name matching.
Testing: a proxy-level test that a CONNECT to api.example.com.:443 yields the same admission decision and middleware chain as api.example.com:443, a case pinning that api.example.com.. stays denied, and a resolution-path check that the original form reaches the resolver.
Alternatives Considered
- Normalize inside
HostPattern::matchesonly: fixes middleware selection but admission still sees the dotted form, so the layers diverge again. - Reject trailing-dot hosts outright at the proxy: closes the middleware gap and is simple, but breaks legitimate root-anchored requests that Kubernetes users rely on, with no benefit over normalization.
- Normalize everywhere including DNS resolution: simpler (one string), but changes which address a root-anchored request reaches in search-domain environments, silently overriding client intent.
Agent Investigation
Findings from the #2027 host matching review:
normalize_host_lookup_keyincrates/openshell-supervisor-network/src/proxy.rsonly strips IPv6 brackets, and only for specific alias lookups; nothing on the request path handles trailing dots.openshell_core::host_pattern::HostPattern::matchesrejects any host containing an empty DNS label, so even**does not matchapi.example.com.; pinned by theuniversal_wildcard_matches_any_hosttest.- Rego
endpoint_allowed(exact branchlower(endpoint.host) == lower(network.host), glob branchglob.match(lower(endpoint.host), ["."], lower(network.host))) also fails against the dotted form; verified against the regorus 0.9.1 globset transformation. - The hostless
allowed_ipsbranch insandbox-policy.regomatches any hostname on the port, making it the only admission path for dotted hosts today.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia dai punti di ingresso del parsing degli host in openshell-supervisor-network e dall’helper host_pattern in openshell-core, quindi esamina sandbox-policy.rego e proxy.rs. Traccia il percorso con cui l’host originale raggiunge la risoluzione DNS, mentre l’host canonico raggiunge l’ammissione, il middleware e il credential matching. Il lavoro è completato quando gli host con e senza punto finale condividono il comportamento di ammissione e middleware, due punti finali consecutivi continuano a essere rifiutati e un test del percorso di risoluzione conserva la forma originale.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- rust
- Ambito
- networking, security
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 68/100